Repository navigation
perf: reduce repeated eval STRING overhead (#1911) - #1931
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Continues the eval STRING performance work from #1911. This round defers compilation setup until the interpreter eval cache misses, removes the interpreter eval cache, replaces synchronized scope stacks with
FastStack, and caches warning-bit strings with invalidation at mutation sites. It also adds reproducible comparison and multi-trial benchmark scripts.The local validation gate passed on the exact source patch:
nice -n 19 timeout 1800 make(BUILD SUCCESSFUL, 6m22s). The changelog entry for #1911 is included.Closes #1911