Repository navigation
fix: clear file EOF and preserve wide unpack checksums - #1924
Merged
Merged
Conversation
fglock
force-pushed
the
fix/io-clearerr-eof-after-growth
branch
from
October 29, 2026 15:33
ebd24bd to
068dd3a
Compare
fglock
changed the title
Reset EOF state after file growth and retain exact integer results for wide unpack checksums. Fixes #1922. Generated with [Codex](https://openai.com/codex/) Co-Authored-By: Codex <codex@openai.com>
fglock
force-pushed
the
fix/io-clearerr-eof-after-growth
branch
from
October 29, 2026 16:46
068dd3a to
6fe6664
Compare
fglock
marked this pull request as ready for review
October 29, 2026 16:47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
IO::Handle::clearerris called, so reads can resume after the file grows.unpackchecksums. Avoid lossy double-precision checks and an incorrect 63-bitQadjustment.cand 63-bitQchecksums.Fixes #1922.
Validation
nice -n 19 make— passed.nice -n 19 make check-links— passed.timeout 120 ./jperl src/test/resources/unit/pack_core_regressions.t— passed.timeout 120 ./jperl --interpreter src/test/resources/unit/pack_core_regressions.t— passed.timeout 600 perl dev/tools/perl_test_runner.pl perl5_t/t/op/pack.t— 14,726/14,726 passed.Log::Procmail0.14 suite passed all 281 tests during the original clearerr investigation.