Repository navigation
fix: stage MakeMaker post-initialize generated files - #1920
Merged
Merged
Conversation
Run MY::post_initialize before staging PM files, preserve its Makefile text, and handle statement modifiers after fat-comma calls with Perl version guards. Generated with [Codex](https://openai.com/codex/) Co-Authored-By: Codex <codex@openai.com>
fglock
force-pushed
the
feature/issue-1919-fix
branch
from
October 29, 2026 12:42
3b67de4 to
83e199e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1919.
PerlOnJava's MakeMaker compatibility layer did not run
MY::post_initialize, so distributions that add generated data files to thePMmapping omitted them frompm_to_blib. The hook now receives the initialized PM map, can add generated sources, and its returned Makefile text is preserved.Also fix brace disambiguation for parenthesized statement modifiers after fat-comma calls, allowing the upstream
$]version guard in the distribution's UTF-8 tests to parse. The parser now treats]as the Perl version punctuation variable.Validation:
provepassed both new regression tests under system Perl.nice -n 19 makepassed.jperlon JVM and interpreter backends.Lingua-ZH-Romanize-Pinyin0.23 build generated and staged both.storefiles through MakeMaker;make testpassed all 77 tests.