Repository navigation
fix: preserve lvalue returns through goto markers - #1917
Merged
Merged
Conversation
Defer lvalue-return validation while a goto &sub control-flow marker is being forwarded, so the replacement subroutine can return its writable undef-valued scalar cell. Keep validation for actual empty lvalue returns. Fixes #1915 Generated with [Codex](https://openai.com/codex/) Co-Authored-By: Codex <codex@openai.com>
Record draft PR #1917 and its current validation state in the project issue queue. Generated with [Codex](https://openai.com/codex/) Co-Authored-By: Codex <codex@openai.com>
fglock
marked this pull request as ready for review
October 28, 2026 16:37
fglock
added a commit
that referenced
this pull request
Oct 28, 2026
Remove the resolved #1915 fix from the active project queue after its delivery in PR #1917. Generated with [Codex](https://openai.com/codex/) Co-Authored-By: Codex <codex@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
goto &subcontrol-flow markers until the replacement subroutine returns its value.goto.Fixes #1915
Validation
c7c805b7a: regression fails on JVM and interpreter.8344ae1: regression passes on JVM and interpreter.nice -n 19 make— passed on the final candidate based on current master.make check-links— passed.Sub::Quote2.006009 full test suite — 15 files, 6,641 tests passed on JVM and interpreter.