Repository navigation
fix: support Encode XS onBOOT callback - #1882
Merged
Merged
Conversation
Resolve nested PerlOnJava launches from the active Java command after %ENV is cleaned, publish LC_TIME for I18N::Langinfo, load IO::Seekable explicitly before FileHandle method aliasing, and bundle User::pwent/User::grent with the Config feature probes they require. Add focused unit coverage for each path and document the compatibility fixes. Generated with [Codex](https://openai.com/codex/) Co-Authored-By: Codex <codex@openai.com>
Register the callback expected by newer Encode.pm after XSLoader::load. Its initialization work is already covered by the Java module initializer. Add a regression test for the strict-subs compilation path. Generated with [OpenAI Codex](https://openai.com/codex) Co-Authored-By: OpenAI Codex <codex@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
onBOOTcallback that newer hostEncode.pminvokes afterXSLoader::load.Validation
nice -n 19 make— passed.prove -v src/test/resources/unit/encode_xsloader_onboot.t— passed on system Perl.timeout 90 ./jperl src/test/resources/unit/encode_xsloader_onboot.t— passed.timeout 90 ./jperl --interpreter src/test/resources/unit/encode_xsloader_onboot.t— passed.Resolves the Encode compatibility failure observed while loading host CPAN modules. Devel::Size remains unported and is tracked separately in #1880.