You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Catalyst upload tempfile is deleted during request in #1642 integration #1795
The #1642 cleanup changes appear to introduce a Catalyst upload lifetime regression. Please triage after #1642 is merged or its implementation settles; this report records integration evidence and avoids duplicating the cleanup implementation.
Reproduction and evidence
In a disposable integration checkout merging PerlOnJava3 PR #1777 (47e9bfb78f1ac790143838fafcf92f852147bc2b) with the #1642 work in PerlOnJava5 PR #1746 (46d9200e5553bc645fe38b4ee341433aff8ae958), the Catalyst release acceptance target reached 3,819/3,820 passing tests and failed:
t/aggregate/live_engine_request_uploads.t: Upload temp file was deleted.
During global destruction, the runtime also reported DESTROY created new reference to dead object 'File::Temp'.
This failure occurred only in the integration run; the PerlOnJava3 #1777 branch's earlier Catalyst acceptance run passed 3,733 tests. The integration build was b124844c9 (test-only merge commit); neither review branch was changed. Because this is a tempfile lifetime/destructor failure, it may have a different root cause from the Mojolicious request and WebSocket failures; it is tracked separately for that reason.
Expected behavior
A Catalyst upload's temporary file remains available for the documented request lifetime and is cleaned up only after its final owner is gone. Global destruction must not resurrect or dereference an already-dead File::Temp object.
Requested follow-up
After #1642 lands, rerun the named test against its final commit, identify which ownership edge is lost, and add focused permanent regression coverage before changing lifecycle cleanup behavior. The run had no output for 600 seconds while waiting on DBIx::Class's _dbictest_global.lock, so it was stopped by the target soft timeout; no conclusion about DBIx::Class regressions is claimed here.
Resolved by merged PR #1872 (commit aeda283). The requested Catalyst::Runtime 5.90132 retest passed all 3,820 tests, including t/aggregate/live_engine_request_uploads.t; the upload lifetime regression has permanent coverage and passes on JVM, interpreter, and system Perl. See the PR validation details: #1872.
Activity
fix: stop rooting released closure capture metadata
fix: stop rooting released closure capture metadata
fix: stop rooting released closure capture metadata
docs: update ownership candidate validation status
fix: stop rooting released closure capture metadata
docs: update ownership candidate validation status
fix: stop rooting released closure capture metadata
docs: update ownership candidate validation status
fix: stop rooting released closure capture metadata
docs: update ownership candidate validation status
fix: stop rooting released closure capture metadata
docs: update ownership candidate validation status
fix: stop rooting released closure capture metadata
docs: update ownership candidate validation status
fix: stop rooting released closure capture metadata
docs: update ownership candidate validation status
fix: stop rooting released closure capture metadata
docs: update ownership candidate validation status
docs: record ownership regressions passing without recovery scan
docs: record owner recovery scan bypass audit
fglock commentedon Oct 26, 2026
Resolved by merged PR #1872 (commit aeda283). The requested Catalyst::Runtime 5.90132 retest passed all 3,820 tests, including t/aggregate/live_engine_request_uploads.t; the upload lifetime regression has permanent coverage and passes on JVM, interpreter, and system Perl. See the PR validation details: #1872.