Repository navigation
ci: upload test results only when tests fail - #1
Merged
Merged
Conversation
Uploading .xcresult bundles on every run counts against the account-wide Actions artifact quota. Keep them for failed runs only. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Actions artifact storage is shared by the whole account. When it fills up, artifact uploads fail in every repo. Ritmo's source release run hit exactly that error: "Artifact storage quota has been hit". Uploading
.xcresultbundles after every run, including passing ones, adds to that quota.Change
The test-results upload step in
.github/workflows/ci.ymlnow runs withif: failure()instead ofif: always(). Results are still uploaded when tests fail. Nothing else changes.Verification
actionlint .github/workflows/ci.ymlreports no new issues. It shows one SC2181 shellcheck style note that predates this change.🤖 Generated with Claude Code