fix: use public endpoint for generated presigned storage URLs - #8
Conversation
* Added `S3_PUBLIC_ENDPOINT` environment configuration to separate the internal MinIO endpoint used by the backend from the public URL seen by browsers. * Updated Zod environment validation and defaults. * Instantiated a separate `publicClient` in `S3ObjectStorageAdapter` initialized with this public endpoint. * `createUploadUrl` and `createDownloadUrl` now use `publicClient`, ensuring correct public-facing URLs. Co-authored-by: fdaei <81993335+fdaei@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
Fixes the issue where presigned URLs generated for uploading and downloading images (and other media) contained the internal development backend endpoint (e.g.
localhost:19000) instead of a proper public endpoint, making them inaccessible to browsers in production.PR created automatically by Jules for task 3881569610533296833 started by @fdaei