fix(release): verify wildcard Cargo dependency pins - #175
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release preparation failed while verifying the derived files for PR #174: sync pinned a local Cargo dependency from
*to0.2.0, but the verifier required the previous value to equal the local package's previous numeric version.Accept wildcard-to-local-version transitions using the existing path and package checks. Regression coverage exercises regular and target-specific dependency tables and continues to reject wrong versions, changed or removed paths, and changed features.
Validation: all six structured release-commit tests pass. Replayed sync and verification against PR #174 at
09793461aff6b593b5077d01eab3dffd76d4ad3e; the original verifier reproduces the failure, and the fixed verifier accepts all 20 selected products and 44 derived paths.Local qualification also passed:
moon run release-tools:unit repo:toolingandmoon run release-tools:metadata, using the pinned Moon 2.5.4 and Bun 1.3.14. The GitHub release-controls audit passed all 39 checks. Runtime builds are unaffected by this verifier-only change.Failed job: https://github.com/f0rr0/oliphaunt/actions/runs/33989155433/job/101368371944