Skip to content

feat: add followSymlinks option to configure symlink traversal (#120) - #245

Closed
vaibhavmashal wants to merge 1 commit into
expressjs:masterfrom
vaibhavmashal:feat/follow-symlinks-option
Closed

vaibhavmashal wants to merge 1 commit into
expressjs:masterfrom
vaibhavmashal:feat/follow-symlinks-option

Conversation

@vaibhavmashal

Copy link
Copy Markdown

Resolves #120

Summary of Changes

  • Added support for the \ ollowSymlinks\ option in \index.js\ (defaults to \ rue).
  • Passed \opts.followSymlinks\ to \send(req, path, opts).
  • Documented \ ollowSymlinks\ option in \README.md.
  • Added unit test suite in \ est/test.js\ for \ ollowSymlinks\ option verification.

Copilot AI lite review requested due to automatic review settings September 8, 2026 16:45

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@krzysdz

krzysdz commented Sep 8, 2026

Copy link
Copy Markdown

send does not have a followSymlinks option.

Please don't open AI-generated PRs with no human review.

@krzysdz krzysdz closed this Sep 8, 2026
@krzysdz krzysdz added the invalid label Sep 8, 2026
@vaibhavmashal

Copy link
Copy Markdown
Author

Thanks for the feedback @krzysdz. The option was implemented in coordination with the corresponding upstream PR in \send\ (pillarjs/send#316 based on #120 and pillarjs/send#297).

I completely agree that \serve-static\ should wait until \send\ officially releases the option before exposing it here. Keeping this closed until then. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Disable symlinks

3 participants