Fix #6957: Replace OS-specific bash commands with cross-platform inline Python - #211
Open
Kaynup wants to merge 1 commit into
Open
Fix #6957: Replace OS-specific bash commands with cross-platform inline Python#211Kaynup wants to merge 1 commit into
Kaynup wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves explosion/spaCy#6957
Description
I have replaced the hardcoded OS-specific bash commands (
mkdir -pandrm -rf) inside theproject.ymlfiles with cross-platform inline Python equivalents. This ensures Windows users to not to manually run utility scripts or edit the YAML themselves.Following the guidance discussed in PR #69 and #73, my approach avoids creating external utility scripts (which add clutter) by instead using lightweight
python -ccommands.To ensure this solution bypasses the string parsing errors encountered in PR #42, I verified the inline python commands natively.
Types of change
Checklist
updatescripts in the.githubfolder, and all the configs and docs are up-to-date.