Repository navigation
Classic off-by-one error in audio track names (All/Custom modes) - #196
Merged
Merged
Conversation
Track%dName config keys are 1-based; the encoder loops use the 0-based mixer index, so mixer 0 fell back to "Track 1" and each name shifted down one track.
Contributor
Author
|
Thanks so much for the Custom option on the audio! It came out just a couple of days after I was looking for it. I found an off-by-one bug in the labeling of the tracks, so I hope this fix helps get that into 0.5.1. Keep up the good work! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Audio track names in the recorded file are off by one when Audio Track is All or Custom. With tracks 1–3 named “Live Stream / Vocals / Instruments” in Output > Audio in OBS, the file’s tracks are labeled “Track 1 / Live Stream / Vocals” (the audio itself is correct). OBS stores names as Track1Name…Track6Name (1-based), but the encoder loops build the key from the 0-based mixer index. The property list loop (1-based) is already correct.