Repository navigation
Install to the OBS 33 plugin location - #43
Closed
Milzstream wants to merge 2 commits into
Closed
Milzstream wants to merge 2 commits into
Milzstream wants to merge 2 commits into
Conversation
Owner
|
I am working on an installer that works on multiple versions of OBS |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OBS 33 changed where third-party plugins are loaded. The old Program Files
obs-plugins\64bitlocation, and a ProgramData bundle that still usesbin\64bit, are legacy. They still load in OBS 33 with a Legacy flag, and stop loading in OBS 34.This updates packaging only. Plugin code and the OBS SDK pin (
31.1.0) are unchanged.New locations
Windows, from Legacy plugin locations and obs-studio#13594:
C:\ProgramData\obs-studio\plugins\source-clone\source-clone.dllC:\ProgramData\obs-studio\plugins\source-clone\data<OBS binary>/../../plugins/source-clone/source-clone.dllplusdatabeside itLinux system packages:
${CMAKE_INSTALL_LIBDIR}/obs-modules/plugins/source-clone.so${CMAKE_INSTALL_DATAROOTDIR}/obs/obs-modules/plugins/source-clone(contents ofdata/, same as before)macOS is unchanged.
What changed
bin\64bit.{commonappdata}\obs-studio\plugins\source-clone, ignores a previous OBS install directory (UsePreviousAppDir=no), and requires OBS 33 or newer when a normal install is found.obs-plugins\64bit\source-clone.dllanddata\obs-plugins\source-clone) from the OBS directory inHKLM\SOFTWARE\OBS Studio, and a leftoverbinfolder in the new plugin directory.pluginsfolder.bin\64bitprogramdata zip. Layout issource-clone/source-clone.dllandsource-clone/data/. PDBs are left out of the installer and zip.0.2.4.Tested
Built from this branch and installed on Windows with OBS 33. After restart, OBS no longer marks the plugin as a legacy install location, and there were no immediate load errors.
Test build: https://github.com/Milzstream/obs-source-clone/releases/tag/0.2.4
Linux and macOS packages were produced by CI. I have not installed those locally.