[Copilot]

css/use-baseline could overflow the stack while ESLint compiled the rule option schema when the environment had less available stack space, as seen with some installs that include node@25.x. The failure happened during config validation, before any CSS file content was analyzed.

• Problem

  • allowPropertyValues built a very large nested JSON schema by enumerating every allowed value for every known property.
  • That schema was expensive enough to trigger Maximum call stack size exceeded in affected environments during rule schema compilation.

• Change

  • Simplify allowPropertyValues schema validation:
    • keep strict validation for property names
    • accept array-of-string values generically instead of enumerating every allowed value in the schema
  • This keeps option shape validation in place while avoiding the deep/generated validator that caused the overflow.

• Regression coverage

  • Add an integration test that loads css/use-baseline in a subprocess with constrained stack space and verifies config compilation succeeds.

• Behavioral impact

  • The rule’s runtime behavior is unchanged.
  • We lose validation of the property values in rule schema.
  • The change is limited to option schema compilation for allowPropertyValues.

allowPropertyValues: {
	type: "object",
	propertyNames: {
		enum: Array.from(properties.keys()),
	},
	additionalProperties: {
		type: "array",
		items: { type: "string" },
		uniqueItems: true,
	},
}

• Fixes Bug: use-baseline exceeds maximum call stack size if node package < 26.0.0 is installed #574

[coderabbitai]

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

• Configuration used: Repository: eslint/coderabbit/.coderabbit.yaml
• Review profile: CHILL
• Plan: Advanced
• Run ID: 27db50f5-c067-473b-a95c-2d309a612157

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[eslint-github-bot]

Hi @Copilot!, thanks for the Pull Request

The pull request title isn't properly formatted. We ask that you update the pull request title to match this format, as we use it to generate changelogs and automate releases.

• The commit message tag wasn't recognized. Did you mean "docs", "fix", or "feat"?
• There should be a space following the initial tag and colon, for example 'feat: Message'.
• The first letter of the tag should be in lowercase
• The length of the commit message must be less than or equal to 72

To Fix: You can fix this problem by clicking 'Edit' next to the pull request title at the top of this page.

Read more about contributing to ESLint here

[eslint-github-bot]

Hi @Copilot!, thanks for the Pull Request

The pull request title isn't properly formatted. We ask that you update the pull request title to match this format, as we use it to generate changelogs and automate releases.

• The commit message tag wasn't recognized. Did you mean "docs", "fix", or "feat"?
• There should be a space following the initial tag and colon, for example 'feat: Message'.
• The first letter of the tag should be in lowercase
• The length of the commit message must be less than or equal to 72

To Fix: You can fix this problem by clicking 'Edit' next to the pull request title at the top of this page.

Read more about contributing to ESLint here

[eslint-github-bot]

Hi @Copilot!, thanks for the Pull Request

The pull request title isn't properly formatted. We ask that you update the pull request title to match this format, as we use it to generate changelogs and automate releases.

• The commit message tag wasn't recognized. Did you mean "docs", "fix", or "feat"?
• There should be a space following the initial tag and colon, for example 'feat: Message'.
• The first letter of the tag should be in lowercase
• The length of the commit message must be less than or equal to 72

To Fix: You can fix this problem by clicking 'Edit' next to the pull request title at the top of this page.

Read more about contributing to ESLint here

[eslint-github-bot]

Hi @Copilot!, thanks for the Pull Request

The pull request title isn't properly formatted. We ask that you update the pull request title to match this format, as we use it to generate changelogs and automate releases.

• The commit message tag wasn't recognized. Did you mean "docs", "fix", or "feat"?
• There should be a space following the initial tag and colon, for example 'feat: Message'.
• The first letter of the tag should be in lowercase
• The length of the commit message must be less than or equal to 72

To Fix: You can fix this problem by clicking 'Edit' next to the pull request title at the top of this page.

Read more about contributing to ESLint here

[eslint-github-bot]

Hi @Copilot!, thanks for the Pull Request

The pull request title isn't properly formatted. We ask that you update the pull request title to match this format, as we use it to generate changelogs and automate releases.

• The commit message tag wasn't recognized. Did you mean "docs", "fix", or "feat"?
• There should be a space following the initial tag and colon, for example 'feat: Message'.
• The first letter of the tag should be in lowercase
• The length of the commit message must be less than or equal to 72

To Fix: You can fix this problem by clicking 'Edit' next to the pull request title at the top of this page.

Read more about contributing to ESLint here

[eslint-github-bot]

Hi @Copilot!, thanks for the Pull Request

The pull request title isn't properly formatted. We ask that you update the pull request title to match this format, as we use it to generate changelogs and automate releases.

• The commit message tag wasn't recognized. Did you mean "docs", "fix", or "feat"?
• There should be a space following the initial tag and colon, for example 'feat: Message'.
• The first letter of the tag should be in lowercase

To Fix: You can fix this problem by clicking 'Edit' next to the pull request title at the top of this page.

Read more about contributing to ESLint here

[nzakas]

@copilot fix failing CI checks

[Copilot]

@copilot fix failing CI checks

Addressed in 69bb161. I fixed the failing checks by making the regression test use the real node executable when the suite runs under Bun, and I formatted the updated test file so the Prettier check passes.

[nzakas]

@copilot with this approach, we lose validation of property values through the rule schema. Can we add back validation inside the create method without reintroducing the same bug?

[DMartens]

If we want to keep the values, we could not construct Set here as globalKeywords.keys and propertyValues.get(prop).keys() have no overlap.
This would also remove the conversion from Set to Array for the enum.
Unfortunately this would be not enough for the test case below with stack size 100.
For me this reliably works for node version 26.10 (unaffected from this bug) with a stack size of 400.

Unfortunately we cannot use iterator helpers (by removing "Array.from()" around "properties.keys()" as we support v20 which also should help with decreasing the required memory.