Skip to content

Release PRs are not being ignored #1

Open

Description

@fasttime

PR eslint/css#594 should have been ignore because of the label "autorelease: pending", but it was reviewed normally.

# Ignore release PRs
labels: ["!autorelease: pending"]

The syntax "!<label>" should cause the PR to be ignored according to the documentation. It's not clear to me if we are missing something.

Activity

  1. electrohyun commented on Oct 21, 2026

    @electrohyun

    Hi, I worked on a related change in eslint/markdown#744.

    You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

    The comment suggests this setting, but I think it would affect other PRs too, so it may be hard to use here.

    I also found ignore_title_keywords and checked a PR using it, but It still gets a Review skipped comment (https://github.com/SickChill/sickchill/blob/master/.coderabbit.yaml#L23 -> SickChill/sickchill#9253).

    If we want CodeRabbit to leave no comment at all, like we did before (eslint/rewrite#512 -> eslint/rewrite#525), then @coderabbitai ignore seems to be the only option I could find for now.

  2. coderabbitai commented on Oct 21, 2026

    @coderabbitai
    🧩 Analysis chain

    🏁 Script executed:

    #!/bin/bash
    set -euo pipefail
    gh issue view 1 --repo eslint/coderabbit --json title,body,comments
    curl -fsSL https://raw.githubusercontent.com/SickChill/sickchill/master/.coderabbit.yaml | nl -ba | head -100
    curl -fsSL https://coderabbit.ai/integrations/schema.v2.json | python -c '
    import json,sys
    data=json.load(sys.stdin)
    def walk(obj,path=""):
        if isinstance(obj,dict):
            for k,v in obj.items():
                p=path+"."+k
                if k in ("review_status","ignore_title_keywords"):
                    print(p,json.dumps(v,indent=2))
                walk(v,p)
        elif isinstance(obj,list):
            for i,v in enumerate(obj): walk(v,path+"."+str(i))
    walk(data)
    '

    Length of output: 5068


    🤖 web_search executed:

    CodeRabbit documentation @coderabbitai ignore pull request description review_status ignore_title_keywords Review skipped no comments

    Length of output: 12996


    @electrohyun Thanks for the clarification. Your distinction is correct: skipping a review does not necessarily suppress the “Review skipped” comment.

    • reviews.review_status: false suppresses review-status messages for all PRs that use that configuration. It does not disable reviews, but its scope is broader than release PRs.
    • reviews.auto_review.ignore_title_keywords skips matching reviews. It does not independently suppress status messages. The linked SickChill configuration also has review_status: true.
    • For per-PR exclusion, put @coderabbitai ignore in the PR description. For generated release PRs, include it in the description when the PR is created.

    That makes @coderabbitai ignore the appropriate option for the release-PR workflow you described, without changing status messages on other PRs.

    The label-filter issue remains separate: a review that runs despite an exclusion label is different from a skipped review that still posts a status comment.


    ✏️ Learnings added
    Learnt from: electrohyun
    URL: https://github.com/eslint/coderabbit/issues/1
    
    Timestamp: 2026-10-21T03:35:35.649Z
    Learning: In the eslint release-PR workflow discussed in eslint/coderabbit issue 1, maintainers want release PRs to receive no CodeRabbit comments while preserving CodeRabbit behavior on other PRs. The user reports that title-based exclusions still produce a “Review skipped” comment and identifies `@coderabbitai ignore` in the release PR description as the per-PR approach used in related ESLint repositories. Do not treat skipping a review and suppressing review-status comments as equivalent requirements.
    

    Note: Learnings are effective only in the context of similar code segments. To apply general coding guidelines, please configure review instructions. You can manage existing learnings in the app.

    You are interacting with an AI system.

  3. electrohyun commented on Oct 21, 2026

    @electrohyun

    @coderabbitai Delete the learning added from my previous comment and do not create a replacement learning.

    (I didn’t mean to add a learning. Sorry for the extra noise.)

  4. coderabbitai commented on Oct 21, 2026

    @coderabbitai

    @electrohyun I cannot delete that learning because its learning ID is not available here. You can delete it from the CodeRabbit learnings page.

    I have not included a replacement learning in this reply.

    You are interacting with an AI system.

  5. coderabbitai commented on Oct 21, 2026

    @coderabbitai

    @electrohyun Thanks for the guidance. I cannot delete the learning because its learning ID is not available in this conversation. The learning has not been deleted.

    You can delete it from the CodeRabbit learnings page. This reply does not create a replacement learning.

    You are interacting with an AI system.

  6. electrohyun commented on Oct 21, 2026

    @electrohyun
    Image

    And I asked the support team to see if there was another option.

    They said there’s currently no setting to hide skip comments only for specific labels, and also recommended the approach mentioned above.

  7. fasttime commented on Oct 21, 2026

    @fasttime
    MemberAuthor

    Maybe we could add eslintbot to the list of ignored users. I don't think any of the bot's PRs needs review, and a review may always be triggered manually with @coderabbitai review. Alternatively, we could set reviews.review_status to false as Coderabbit suggests to suppress the noisy comment.

  8. nzakas commented on Oct 22, 2026

    @nzakas
    Member

    8. Alternatively, we could set reviews.review_status to false as Coderabbit suggests to suppress the noisy comment.

    I'd be fine with that. I don't think there's anything we'd miss if we enabled this for all skipped PRs. Why would we care for CodeRabbit to confirm it didn't check the PR?

  9. fasttime commented on Oct 23, 2026

    @fasttime
    MemberAuthor
    1. Alternatively, we could set reviews.review_status to false as Coderabbit suggests to suppress the noisy comment.

    I'd be fine with that. I don't think there's anything we'd miss if we enabled this for all skipped PRs. Why would we care for CodeRabbit to confirm it didn't check the PR?

    I'm working on this.

  10. self-assigned this
    on Oct 23, 2026
  11. eslint-github-bot commented on Oct 23, 2026

    @eslint-github-bot

    👋 Hi! This issue is being addressed in pull request #2. Thanks, @fasttime!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

bugSomething isn't working

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions