Repository navigation
Conversation
…/-int16, Faces, Axes, Content
…int16, Faces, Axes, Content
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Good Afternoon, @ericplane
I'm genuinely glad this library has emerged as a replacement for the now rather outdated ProfileStore. It's the only DataStore library that's actually a pleasure to work with.
Why?
I'm currently developing my own game, and the only shortcoming I've found in the library is the absence of several fairly important types —
Ray,Region3,Region3int16,Faces,Axes, andContent. So I decided to implement them myself to help make the library a bit better and more complete; these types will be useful to developers whose games rely on them frequently.What has been changed:
types/index.d.ts— Added the new types to theScribeModuleinterface (alongside the existingreadonly Vector3/CFrame/etc. lines) and added the same six types to theDatatypeValuesinterface.src/Internal/datatypes.luau— Added the new types (Ray,Region3,Region3int16,Faces,Axes,Content) tocodecsfor replication and profile saving.src/init.luau— Added six new functions toScribefor the new types (Ray,Region3,Region3int16,Faces,Axes,Content) and updated the shared doc comment abovefunction Scribe.Vector3as well as the@prop Datatypes tabledoc comment.What was intentionally left unchanged?
Documentation — I chose not to touch it, since the current build (v2.5.0) doesn't yet include these changes; adding types to the docs that don't exist in the build yet would only cause confusion.