Repository navigation
"Launch price" follows Pro's live price, so a price step hides it without an update (#908) - #910
Merged
Merged
Conversation
Skeyelab
enabled auto-merge (squash)
October 21, 2026 18:36
…hout an update (#908) The label came from a fixed PriceStage.current = .launch, so after a price step every installed copy would still say "Launch price" beside $9.99. StoreKit gives no price tier, so the app now compares Pro's live price, rounded to the cent, with Pro's launch price in that currency, read from App Store Connect on 2026-10-21 (43 currencies). Anything else hides it. Assisted-by: Claude Code:claude-opus-5-5
Skeyelab
force-pushed
the
agent3/launch-price
branch
from
October 21, 2026 18:36
642b11b to
3d5d81b
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #908.
What changed
The "Launch price" line under the Pro offers (Settings' Pro section and the paywall) came from a fixed
PriceStage.current = .launch. After a price step in App Store Connect, every installed copy would still say "Launch price" beside $9.99 until it updated. Eric's decision: the label follows the live price.What I chose for the comparison
StoreKit 2's
Productexposes no price tier or price-point ID, onlyprice,displayPriceandpriceFormatStyle.currencyCode. So:PriceStage.label(proPrice:currencyCode:)shows "Launch price" only when Pro's live price, rounded to the cent, equals Pro's launch price in the storefront's currency.The pack and upgrade offers also key the label on Pro's price, because the ladder moves all the prices together (ADR 0004).
Tests
PackOfferTestsfailed to compile (PriceStage.label(proPrice:currencyCode:)didn't exist), then passed.Decimal(4.99)failed the match, which the Code Reviewer flagged as possible StoreKit float residue. Rounding to the cent made it pass../scripts/verify.shpassed, andVERIFY_QUICK=1passed after the rounding fix.Checked only by tests and the builds. Not checked on a device: what
Product.priceholds in a TestFlight build. The Xcode StoreKit config is USA at 4.99, so Debug and the Simulator still show the label.Docs: ADR 0004 records the decision, and the App Store Connect steps no longer mention a one-line stage PR.