Skip to content

Fix fmu_copy_revision prints wrong disk space above 1024 g - #886

Open
HakonSohoel wants to merge 2 commits into
equinor:mainfrom
HakonSohoel:fix-fmu_copy_revision-prints_wrong-disk-space-above-1024-G
Open

HakonSohoel wants to merge 2 commits into
equinor:mainfrom
HakonSohoel:fix-fmu_copy_revision-prints_wrong-disk-space-above-1024-G

Conversation

@HakonSohoel

@HakonSohoel HakonSohoel commented Sep 18, 2026

Copy link
Copy Markdown

_filesize() divided size by 1024 one extra time when it reached
the largest supported unit ("G"), reporting revisions >= 1024 G in the
wrong magnitude (e.g. 2.0 T showed as 2.0 G)

_filesize() divided size by 1024 one extra time when it reached
the largest supported unit ("G"), reporting revisions >= 1024 G in the
wrong magnitude (e.g. 2.0 T showed as 2.0 G)
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 86.66667% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 84.28%. Comparing base (2579f6d) to head (dd68a53).

Files with missing lines Patch % Lines
...c/subscript/fmu_copy_revision/fmu_copy_revision.py 86.66% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #886   +/-   ##
=======================================
  Coverage   84.28%   84.28%           
=======================================
  Files          49       49           
  Lines        7530     7530           
=======================================
  Hits         6347     6347           
  Misses       1183     1183           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@HakonSohoel
HakonSohoel requested review from alifbe and larsevj and removed request for larsevj September 23, 2026 07:54

@alifbe alifbe left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants