Skip to content

fix(release): bump to 4.2.0 so the scrollbar removal ships - #156

Merged
tmccoy14 merged 1 commit into
mainfrom
fix/publish-4.2.0
Sep 23, 2026
Merged

tmccoy14 merged 1 commit into
mainfrom
fix/publish-4.2.0

Conversation

@tmccoy14

Copy link
Copy Markdown
Contributor

Why

The scrollbar removal from #150 is on main, built and correct, but has never been published. Everything downstream still installs the pre-removal artifact.

What happened, from the commit dates:

  • Sep 21 — 1a06cf5 "bump equality version" set 4.0.0 → 4.1.0 on main. That touched packages/ui/package.json, which fired publish.yaml. npm had no 4.1.0, so CI built main as it stood that day — before the removal — and published it.
  • Sep 22 — feat: depreceate scroll-area component and styled scrollbars #150 squash-merged the removal. Its only change to package.json was adding CHANGELOG.md to files; the version stayed 4.1.0. The workflow fired, found 4.1.0 already on npm, and hit the "version already exists; skipping publish" guard.

So published 4.1.0 still carries styled-vertical-scrollbar and styled-horizontal-scrollbar, still ships theme-components.css, and still applies the vertical utility to DialogContent and SheetContent.

Downstream effect

Anyone who follows the migration guide today ends up with mismatched scrollbars: native everywhere they migrated, and the restyled 6px #7f738f bar inside Dialog and Sheet, which are the only two components the library applies that class to. That is how this surfaced — guardian/apps/studio migrated its five <ScrollArea /> usages and the dialogs no longer match the rest of the app.

What this changes

One line: packages/ui/package.json 4.1.0 → 4.2.0. No source changes — main is already correct. 4.2.0 is the version the CHANGELOG entry from #150 already names, and it is unpublished on npm.

publish.yaml triggers on a push to main touching packages/ui/package.json, and pnpm run release builds before publishing, so merging this ships a fresh build.

Verification

Against a clean rm -rf dist && pnpm run build:

  • no styled-vertical-scrollbar / styled-horizontal-scrollbar anywhere in dist
  • no theme-components.css, and no stylesheet left @import-ing it (a dangling import would break every consumer's CSS build)
  • DialogContent renders cn(styles["dialog-body"], className) only
  • .dialog-body keeps overflow: auto, so dialog bodies still scroll — just with the native bar
  • ScrollArea / ScrollBar still exported, carrying their @deprecated JSDoc — deprecated, not removed

🤖 Generated with Claude Code

The version bump to 4.1.0 landed on main a day before #150, so publish.yaml
built and released main as it stood then — before the removal. #150 then
merged the removal without touching the version, and the workflow skips a
version npm already has, so the clean build has sat on main unpublished.

Published 4.1.0 therefore still carries styled-vertical-scrollbar and
styled-horizontal-scrollbar, still ships theme-components.css, and still
applies the vertical utility to DialogContent and SheetContent. Consumers
following the migration guide get native scrollbars everywhere except inside
Dialog and Sheet, which keep the restyled 6px bar.

4.2.0 is the version the CHANGELOG entry from #150 already names.

Verified against a clean rebuild: no utility classes anywhere in dist, no
theme-components.css, no stylesheet left importing it, DialogContent renders
only dialog-body, .dialog-body keeps overflow:auto so it still scrolls, and
ScrollArea/ScrollBar are still exported with their @deprecated JSDoc.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@tmccoy14 tmccoy14 self-assigned this Sep 23, 2026
@tmccoy14
tmccoy14 merged commit 2651542 into main Sep 23, 2026
1 check passed
@tmccoy14
tmccoy14 deleted the fix/publish-4.2.0 branch September 23, 2026 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant