fix(release): bump to 4.2.0 so the scrollbar removal ships - #156
Merged
Merged
Conversation
The version bump to 4.1.0 landed on main a day before #150, so publish.yaml built and released main as it stood then — before the removal. #150 then merged the removal without touching the version, and the workflow skips a version npm already has, so the clean build has sat on main unpublished. Published 4.1.0 therefore still carries styled-vertical-scrollbar and styled-horizontal-scrollbar, still ships theme-components.css, and still applies the vertical utility to DialogContent and SheetContent. Consumers following the migration guide get native scrollbars everywhere except inside Dialog and Sheet, which keep the restyled 6px bar. 4.2.0 is the version the CHANGELOG entry from #150 already names. Verified against a clean rebuild: no utility classes anywhere in dist, no theme-components.css, no stylesheet left importing it, DialogContent renders only dialog-body, .dialog-body keeps overflow:auto so it still scrolls, and ScrollArea/ScrollBar are still exported with their @deprecated JSDoc. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The scrollbar removal from #150 is on
main, built and correct, but has never been published. Everything downstream still installs the pre-removal artifact.What happened, from the commit dates:
1a06cf5 "bump equality version"set 4.0.0 → 4.1.0 onmain. That touchedpackages/ui/package.json, which firedpublish.yaml. npm had no 4.1.0, so CI builtmainas it stood that day — before the removal — and published it.package.jsonwas addingCHANGELOG.mdtofiles; the version stayed 4.1.0. The workflow fired, found 4.1.0 already on npm, and hit the "version already exists; skipping publish" guard.So published 4.1.0 still carries
styled-vertical-scrollbarandstyled-horizontal-scrollbar, still shipstheme-components.css, and still applies the vertical utility toDialogContentandSheetContent.Downstream effect
Anyone who follows the migration guide today ends up with mismatched scrollbars: native everywhere they migrated, and the restyled 6px
#7f738fbar inside Dialog and Sheet, which are the only two components the library applies that class to. That is how this surfaced —guardian/apps/studiomigrated its five<ScrollArea />usages and the dialogs no longer match the rest of the app.What this changes
One line:
packages/ui/package.json4.1.0 → 4.2.0. No source changes —mainis already correct. 4.2.0 is the version the CHANGELOG entry from #150 already names, and it is unpublished on npm.publish.yamltriggers on a push tomaintouchingpackages/ui/package.json, andpnpm run releasebuilds before publishing, so merging this ships a fresh build.Verification
Against a clean
rm -rf dist && pnpm run build:styled-vertical-scrollbar/styled-horizontal-scrollbaranywhere indisttheme-components.css, and no stylesheet left@import-ing it (a dangling import would break every consumer's CSS build)DialogContentrenderscn(styles["dialog-body"], className)only.dialog-bodykeepsoverflow: auto, so dialog bodies still scroll — just with the native barScrollArea/ScrollBarstill exported, carrying their@deprecatedJSDoc — deprecated, not removed🤖 Generated with Claude Code