feat(select-search): add SelectSearch and SelectEmpty - #155
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Select
- SelectSearch is visible and focused on open by default; alwaysVisible={false}
reveals it on the first keystroke instead.
- Enter in the search box selects the first match, only while a query is active.
- Group labels are hidden rather than unmounted while searching, so SelectGroup's
aria-labelledby resolves; groups with no matches hide.
- Reopening through a controlled `open` clears the previous search.
- Consumer props can no longer override role, hidden, aria-controls or the
search data attribute; the forwarded input ref is stable.
DropdownMenu, FilterDropdown, RadioDropdown
- Search state, matching and focus handling now live in lib/list-search.ts,
shared with Select; match counting is O(1) per item change.
- Enter activates the first match while a query is active.
- A searchable FilterDropdown or RadioDropdown shows its search box on open,
in place of the menu heading, and names it after `label`.
- FilterDropdown's "Clear all" is now a menu item that keyboard and screen
reader users can reach: inline in the "Filters" heading without search, a
sticky footer with it.
Also
- dropdown-search, dropdown-search-input and dropdown-empty theme utilities.
- Component tests for Select, DropdownMenu, FilterDropdown and RadioDropdown,
and for list-search.
- Docs: keyboard and accessibility notes, props tables in the
create-documentation format; Select's llms.txt description mentions search.
- Skill: Select with SelectSearch in the name translation table, free-text
autocomplete listed as a gap.
- 4.3.0 changelog.
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
tmccoy14
approved these changes
Sep 24, 2026
tmccoy14
left a comment
tmccoy14
left a comment
Contributor
There was a problem hiding this comment.
@bhavna-Jin I extended the capabilities to <FilterDropdown /> and <RadioDropdown /> - this is great - thanks 🚀
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What:
Adds a search functionality in the
selectcomponent similar to thedropdown-menuWhy:
This was done to fix : https://linear.app/eqty-lab/issue/MIC-54/associate-agent-search
screenshot 1:
screenshot 2: