Preserve sticky module requirements during purge - #693
Conversation
a005bf0 to
2f4a98e
Compare
| } | ||
|
|
||
| proc getStickyReqUnloadMsg {{tag sticky}} { | ||
| return "Unload skipped because module is required by a $tag module" |
There was a problem hiding this comment.
Use a shorter message structure: Unload of $tag module requirement skipped
xdelaruelle
left a comment
xdelaruelle
left a comment
There was a problem hiding this comment.
Testsuite should be fixed as CI jobs are failing.
Documentation should be adapted to mention this behavior change, especially in module.rst, changes.rst, the sticky/module-tags design docs and the sticky-modules cookbook.
Also good to check if this has an impact on other stuff mentioning sticky modules like stash-environment, initial-environment, conflict_unload, evaluation-errors. Check these design doc and adapt them if required.
2f4a98e to
18f8719
Compare
Purge skips sticky and super-sticky modules but still attempts to unload their non-sticky requirements. This reports an unrelated dependency error without explaining why the requirement remains loaded. Preserve requirements needed by retained sticky modules and apply the sticky_purge reporting mode to their skipped unload. Fixes envmodules#582 Assisted-by: Codex:gpt-5.6-sol Codex:gpt-6-astra Signed-off-by: Adrien Cotte <adrien.cotte@asplus.fr>
18f8719 to
4d70791
Compare
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. ℹ️ You can also turn on project coverage checks and project coverage reporting on Pull Request comment Thanks for integrating Codecov - We've got you covered ☂️ |
2 participants
Purge skips sticky and super-sticky modules but still attempts to unload their non-sticky requirements. This reports an unrelated dependency error without explaining why the requirement remains loaded.
Preserve requirements needed by retained sticky modules and apply the sticky_purge reporting mode to their skipped unload.
Fixes #582
Assisted-by: Codex:gpt-5.6-sol