Repository navigation
Update ports to remove -D_LIBCPP_KEEP_TRANSITIVE_INCLUDES_LLVM23 - #28203
Merged
Merged
Conversation
libc++'s LLVM 23 update (emscripten-core#28149) removed transitive includes (llvm/llvm-project#195509), after which we some of our ports needed `-D_LIBCPP_KEEP_TRANSITIVE_INCLUDES_LLVM23` to compile. I've submitted fixes to those ports: - emscripten-ports/Cocos2d#6 - google/dawn#93, which was merged in google/dawn@aaf0394 - pongasoft/emscripten-glfw#33, after which its TAG and SHA was updated in emscripten-core#28166 This updates version numbers and SHAs for Cocos2d and dawn and removes the `-D_LIBCPP_KEEP_TRANSITIVE_INCLUDES_LLVM23` flag from our ports build. This also adds `-std=c++20` to two tests using Cocos2d because this update (which includes 6 months of work) includes C++20 features.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates several ports and their associated tests. Specifically, it bumps the cocos2d port to version 3.5 and the emdawnwebgpu port to version v20261105.214757, updating their respective hashes and test paths. It also adds the -std=c++20 compiler flag to WebGPU-related tests, removes the temporary -D_LIBCPP_KEEP_TRANSITIVE_INCLUDES_LLVM23 compiler flag from port builds, and refines the curl command in the hash computation documentation. There are no review comments, so I have no feedback to provide.
sbc100
approved these changes
Nov 7, 2026
aheejin
commented
Nov 7, 2026
| @staticmethod | ||
| def fetch_project(name, url, sha512hash=None): | ||
| # To compute the sha512 hash, run `curl URL | sha512sum`. | ||
| # To compute the sha512 hash, run `curl -sSfL URL | sha512sum`. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
libc++'s LLVM 23 update (#28149) removed transitive includes (llvm/llvm-project#195509), after which we some of our ports needed
-D_LIBCPP_KEEP_TRANSITIVE_INCLUDES_LLVM23to compile.I've submitted fixes to those ports:
This updates version numbers and SHAs for Cocos2d and dawn and removes the
-D_LIBCPP_KEEP_TRANSITIVE_INCLUDES_LLVM23flag from our ports build.This also adds
-std=c++20to two tests using Cocos2d because this update (which includes 6 months of work) includes C++20 features.