Fix PE icon embedding (rcedit /I parity) and stale cert parsing - #3
Merged
Conversation
rcedit can leave a certificate data directory that points past the file; treat that as unsigned instead of crashing binary_part/3 during mix pe.update. Co-authored-by: Cursor <cursoragent@cursor.com>
Implement LibPE.ICO / LibPE.Icon so --set-icon writes RT_GROUP_ICON + RT_ICON payloads (WinRun4J rcedit /I semantics), bump to 1.3.0, and add golden/structure tests. Replace the broken Erlang Solutions apt install in CI with erlef/setup-beam so mix test can run on ubuntu-latest. Co-authored-by: Cursor <cursoragent@cursor.com>
dominicletz
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
binary_part/3crash after rcedit).--set-icon/--get-iconviaLibPE.ICO+LibPE.Icon(RT_GROUP_ICON+RT_ICONpayloads matching WinRun4J rcedit/I)..rsrcsections getINITIALIZED_DATA | MEM_READcharacteristics.ubuntu-latest; useerlef/setup-beam.Test plan
mix test(13 tests) locally