Windows host-first: do not install release-first erl .env - #22
Merged
Conversation
Host-first starts BEAM via bin/<app>.bat, which already passes -boot. Installing rel/win32/app.env.eex onto the renamed erl embeds a second -boot in ERL_AFLAGS, so OTP exits with Conflicting -boot options and the GUI host looks dead on click. Co-authored-by: Cursor <cursoragent@cursor.com>
Skipping the write was not enough when a prior packaging left dDrive.exe.env in erts/bin; remove it explicitly for host_first. Co-authored-by: Cursor <cursoragent@cursor.com>
Host-first only applied Pe.Update to the renamed erts erl binary, so Explorer/taskbar showed a blank default icon for dDrive.exe. Copy the host then --set-icon from the release icon.ico. Co-authored-by: Cursor <cursoragent@cursor.com>
Host-first shortcuts now use the embedded host PE icon; other icon paths are normalized to forward slashes so CreateShortCut keeps separators. Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
Author
|
@cursoragent /babysit |
|
Taking a look!   |
Extract host-first env-file sync and PE update args into helpers so mix lint stays under the cyclomatic complexity threshold. Co-authored-by: Dominic Letz <dominicletz@users.noreply.github.com>
Contributor
Author
|
Babysitting update: CI was failing on a Credo cyclomatic-complexity check in Pushed |
Contributor
Author
|
CI is green on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
windows_layout: :host_first, skip writingrel/win32/app.env.eexonto the renamederlexecutable.-bootinERL_AFLAGS. Host-first already starts viabin/<app>.bat, which also passes-boot, so OTP exits with Conflicting -boot options and the GUI host appears to do nothing on click.Test plan
.envfailsbin/app.bat startwith Conflicting -boot options.envlets BEAM boot; host and endpoint connect