Windows host-first packaging for DesktopWebView - #20
Merged
Conversation
Default windows_layout places the native host and ini at the package root with the Mix release under beam/, matching the macOS host-first layout so NSIS shortcuts launch DesktopWebView.exe without heart.
Prefer bin/<app>.bat in DesktopWebView.ini so hosts spawn correctly. Skip IMAGE_SUBSYSTEM_WINDOWS_GUI for host-first packages so OTP 26 user/logger can attach a console when the native host starts BEAM. Co-authored-by: Cursor <cursoragent@cursor.com>
Copy DesktopWebView.exe to host_executable or <name>.exe (e.g. dDrive.exe) and write matching <basename>.ini so taskbar pins and shortcuts keep working. Co-authored-by: Cursor <cursoragent@cursor.com>
Extract host naming, ini writing, release copy, and redistributable moves from release_host_first so mix credo stays green in CI. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
windows_layout: :host_firstplaces the native host +.iniat the package root and the Mix release underbeam/(mirrors macOS host-first).host_binary/DESKTOP_HOST_BINARY/DESKTOP_WEBVIEW_BINARYorpriv/native/windows/*.exe.package.host_executableor<package.name>.exe(e.g.DesktopWebView.exe→dDrive.exe) and write matching<basename>.ini.app_name = <app>.batin the host ini; keep the BEAM/erlbinaries as CUI (host spawns a hidden console).hearton host-first.:release_firstfor legacy wx/heart installers.Test plan
MIX_ENV=prod mix desktop.installerwithDESKTOP_HOST_BINARYproduces_build/prod/<name>/dDrive.exe+dDrive.ini+beam/windows_layout: :release_firststill packs flat release +run.vbs