Skip to content

Use Granite.Box and css spacing - #582

Merged
stsdc merged 7 commits into
stsdc/better-indicatorfrom
danirabbit/indicator-cssspacing
Oct 15, 2026
Merged

stsdc merged 7 commits into
stsdc/better-indicatorfrom
danirabbit/indicator-cssspacing

Conversation

@danirabbit

@danirabbit danirabbit commented Oct 13, 2026 •

Copy link
Copy Markdown
Member
Screenshot from 2026-10-13 12 16 32
  • Improve code style
  • Use CSS to set spacing for widgets inside a revealer
  • Remove hardcoded margins, use BASELINE_CENTER
  • Make labels slightly smaller to save space

@danirabbit
danirabbit requested a review from stsdc October 13, 2026 19:16

@stsdc stsdc left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Spacings feel right now!

But looks like ERROR and WARNING css classes do not take effect on labels.
Not sure if that's because of GTK4 Wingpanel or something else...

Image

Comment thread src/Indicator/Widgets/IndicatorWidgetPercentage.vala
@danirabbit

Copy link
Copy Markdown
Member Author

Oops good catch. Will fix

@stsdc stsdc left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! It works!
image

@stsdc
stsdc merged commit 8909ae1 into stsdc/better-indicator Oct 15, 2026
2 of 7 checks passed
@stsdc
stsdc deleted the danirabbit/indicator-cssspacing branch October 15, 2026 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants