[jeremypw]

• Check we have info before trying.
• Avoid creating a local FileInfo object and using it in callback closure.
• Do not check is admin again after earlier return if true.

[lenemter]

Suggested change

	GLib.FileInfo inf;
	dir.location.set_attributes_async.end (res, out inf);
	dir.location.set_attributes_async.end (res, null);

[lenemter]

What warnings does this silence? I still get these:

** (io.elementary.files:99375): WARNING **: 21:28:02.703: plugin.vala:27: Error when getting information for file “/home/leo/Documents/wingpanel/.editorconfig”: No such file or directory

** (io.elementary.files:99375): WARNING **: 21:28:03.962: plugin.vala:27: Error when getting information for file “/home/leo/Documents/wingpanel/README.md”: No such file or directory

** (io.elementary.files:99375): WARNING **: 21:28:04.537: plugin.vala:27: Error when getting information for file “/home/leo/Documents/wingpanel/meson_options.txt”: No such file or directory

** (io.elementary.files:99375): WARNING **: 21:28:06.408: plugin.vala:27: No such file or directory

** (io.elementary.files:99375): WARNING **: 21:28:08.428: plugin.vala:27: No such file or directory

[jeremypw]

@lenemter Thanks for the review. Did you install the PR? You need to do this when plugin code is changed.

[lenemter]

Yes, I installed the PR and verified that the plugin files in /usr/lib/x86_64-linux-gnu/io.elementary.files/plugins/core have changed

[jeremypw]

Hmm, you are right this no longer fixes the warning from plugin.vala:27. Another commit must have changed timing or something. Will redo.

[jeremypw]

Although looking at the diff maybe it was a different message to do with sort column rather than color tag? I am afraid I don't really remember now. Sorry, I should have documented it.