Skip to content

[8.19] (backport #22390) fix flaky test TestApprovedMetrics - #22398

Merged
mergify[bot] merged 1 commit into
8.19from
mergify/bp/8.19/pr-22390
Nov 6, 2026
Merged

mergify[bot] merged 1 commit into
8.19from
mergify/bp/8.19/pr-22390

Conversation

@mergify

@mergify mergify Bot commented Nov 6, 2026

Copy link
Copy Markdown
Contributor

Motivation/summary

commit attempts a fix on TestApprovedMetrics by filtering out server aggregates to focus on agent metrics.

Checklist

  • Not a user facing change

For functional changes, consider:

  • Is it observable through the addition of either logging or metrics?
  • Is its use being published in telemetry to enable product improvement?
  • Have system tests been added to avoid regression?

How to test these changes

Related issues

fixes: #21608


This is an automatic backport of pull request #22390 done by [Mergify](https://mergify.com).

* fix flaky test TestApprovedMetrics

commit attempts a fix on TestApprovedMetrics by filtering out
server aggregates to focus on agent metrics.

fixes: #21608

* remove additional tick in metricset.json

(cherry picked from commit 906852a)
@mergify
mergify Bot requested a review from a team as a code owner November 6, 2026 13:42
@mergify mergify Bot added the backport label Nov 6, 2026
Copilot AI balanced review requested due to automatic review settings November 6, 2026 13:42
@github-actions

github-actions Bot commented Nov 6, 2026

Copy link
Copy Markdown
Contributor

🤖 GitHub comments

Just comment with:

  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues are reported for the backport that excludes server-generated aggregates from the metrics approval check.

No open issues 🎉

What changed in this PR

This backport addresses flaky TestApprovedMetrics failures reported in #21608 by excluding server-generated aggregates from the agent-metrics approval check.

Changes:

  • Filter out metrics with metricset.interval, rather than excluding only transaction metrics.
  • Remove a stray trailing backtick from the metricset intake fixture.
File Description
testdata/​intake-v2/​metricsets.ndjson Remove a trailing backtick to restore valid NDJSON.
systemtest/​metrics_test.go Exclude all server-aggregated metrics from the approval check.

Review effort: Balanced

@infra-vault-gh-plugin-prod

Copy link
Copy Markdown

💚 Build Succeeded

cc @aelnahas

@github-actions

github-actions Bot commented Nov 6, 2026

Copy link
Copy Markdown
Contributor

Dependency review finished without posting an analysis comment.

If you expected a review, push a new commit to this pull request (or close and reopen it) to try again.

Workflow run: https://github.com/elastic/apm-server/actions/runs/42227651614

@mergify mergify Bot added the queued label Nov 6, 2026
@mergify

mergify Bot commented Nov 6, 2026 •

Copy link
Copy Markdown
Contributor Author

✅ Merged into 8.19 as 62b62f4 at 16:44 UTC

12 min in the queue, 10 min of it CI.

So far

9 merge conditions met
  • check-success=CLA
  • check-success=lint
  • check-success=system-test
  • check-success=test (macos-latest)
  • github-review-approved · required by GitHub branch protection, GitHub repository ruleset rule [org] Require a PR for Renovate and GitHub repository ruleset rule [org] Require a PR
  • any of:
    • check-success=test (windows-2025)
    • check-success=test (windows-latest)
  • any of · required by GitHub branch protection:
    • check-success = CLA
    • check-neutral = CLA
    • check-skipped = CLA
  • any of · required by GitHub branch protection:
    • check-success = lint
    • check-neutral = lint
    • check-skipped = lint
  • any of · required by GitHub branch protection:
    • check-success = buildkite/docs-build-pr
    • check-neutral = buildkite/docs-build-pr
    • check-skipped = buildkite/docs-build-pr

Times in UTC · dashboard · how the merge queue works

@mergify
mergify Bot merged commit 62b62f4 into 8.19 Nov 6, 2026
43 checks passed
@mergify
mergify Bot deleted the mergify/bp/8.19/pr-22390 branch November 6, 2026 16:44
@mergify mergify Bot removed the queued label Nov 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants