Repository navigation
[9.5] (backport #22390) fix flaky test TestApprovedMetrics - #22396
Merged
Merged
Conversation
Contributor
🤖 GitHub commentsJust comment with:
|
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
There are no active review issues for the backport targeting flaky metric approval checks.
No open issues 🎉
What changed in this PR
Backports #22390 to 9.5 to address flaky TestApprovedMetrics results reported in #21608, keeping approval checks focused on agent metrics rather than server-generated aggregates.
Changes:
- Excludes metrics with
metricset.intervalfrom the approval query, covering all server aggregate types. - Removes a stray trailing backtick from the metricset intake fixture.
| File | Description |
|---|---|
testdata/intake-v2/metricsets.ndjson |
Removes an invalid trailing character from the final metricset record. |
systemtest/metrics_test.go |
Broadens aggregate filtering and updates the explanatory comment. |
Review effort: Balanced
💚 Build Succeeded
cc @aelnahas |
Contributor
|
Dependency review finished without posting an analysis comment. If you expected a review, push a new commit to this pull request (or close and reopen it) to try again. Workflow run: https://github.com/elastic/apm-server/actions/runs/42227617001 |
aelnahas
approved these changes
Nov 6, 2026
Contributor
Author
✅ Merged into
|
Closed
24 of 37 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation/summary
commit attempts a fix on TestApprovedMetrics by filtering out server aggregates to focus on agent metrics.
Checklist
For functional changes, consider:
How to test these changes
Related issues
fixes: #21608
This is an automatic backport of pull request #22390 done by [Mergify](https://mergify.com).