Repository navigation
Phone image: run the streamer's host tests from their directory - #1428
Conversation
Since #1425, fleet/phone/streamer/test_host.cpp reads main.cpp beside it through __FILE__, which is the relative path the Containerfile's make compiled it with, so the image build ran build/test-host from / and the check "the phone streamer configures the scene token before it listens" failed with main.cpp unreadable. That stopped every phone image build, the host AMI's included. The build stage now runs the tests from the streamer's directory. Test: podman build --target streamer with main's Containerfile fails at test_host.cpp:48 (70 passed, 1 failed); with this one, 71 passed.
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Caution Review failedThe pull request is closed. Walkthrough
Merge Risk:
|
|
Codex Review: Didn't find any major issues. Already looking forward to the next diff. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
ejc3
left a comment
There was a problem hiding this comment.
NOT-A-DEFECT: the review bodies on this PR (CodeRabbit's summary or notice, Codex's receipt) carry no finding of their own.
The phone image build fails on main: since #1425 the streamer's
test_host.cppreadsmain.cppthrough__FILE__, which is relative under the Containerfile'smake -C, and the build ranbuild/test-hostfrom/. Found building the host AMI from main 91f52a5 (its build phase stopped attest_host.cpp:48). The stage now runs the tests from the streamer's directory.Evidence:
podman build --target streamerwith main's Containerfile:FAIL test_host.cpp:48 ... the phone streamer configures the scene token before it listens, 70 passed, 1 failed; with this change: 71 checks passed.Summary by CodeRabbit