Skip to content

Phone image: run the streamer's host tests from their directory - #1428

Merged
ejc3 merged 1 commit into
mainfrom
fix/phone-image-test-host
Oct 29, 2026
Merged

ejc3 merged 1 commit into
mainfrom
fix/phone-image-test-host

Conversation

@ejc3

@ejc3 ejc3 commented Oct 29, 2026 •

Copy link
Copy Markdown
Owner

The phone image build fails on main: since #1425 the streamer's test_host.cpp reads main.cpp through __FILE__, which is relative under the Containerfile's make -C, and the build ran build/test-host from /. Found building the host AMI from main 91f52a5 (its build phase stopped at test_host.cpp:48). The stage now runs the tests from the streamer's directory.

Evidence: podman build --target streamer with main's Containerfile: FAIL test_host.cpp:48 ... the phone streamer configures the scene token before it listens, 70 passed, 1 failed; with this change: 71 checks passed.

Summary by CodeRabbit

  • Chores
    • Updated the phone streamer build to run its test host from the expected location, allowing it to resolve its source files correctly. This change affects the build process only; no end-user features or behavior were changed.

Since #1425, fleet/phone/streamer/test_host.cpp reads main.cpp beside it
through __FILE__, which is the relative path the Containerfile's make
compiled it with, so the image build ran build/test-host from / and the
check "the phone streamer configures the scene token before it listens"
failed with main.cpp unreadable. That stopped every phone image build,
the host AMI's included. The build stage now runs the tests from the
streamer's directory.

Test: podman build --target streamer with main's Containerfile fails at
test_host.cpp:48 (70 passed, 1 failed); with this one, 71 passed.
@ejc3

ejc3 commented Oct 29, 2026

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 29, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-29T11:31:39.111075Z 04d93cd Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@coderabbitai

coderabbitai Bot commented Oct 29, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Caution

Review failed

The pull request is closed.

Walkthrough

The streamer build now runs build/test-host from /src/phone/streamer. A comment notes that the test resolves main.cpp relative to its execution location.

Changes: Streamer host test

Layer / File(s) Summary
Host-test invocation
fleet/phone/Containerfile
The build changes to /src/phone/streamer before running test-host. A comment notes that the test resolves main.cpp relative to its execution location.

Priority: Not assessed

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Bug fix

Possibly related PRs

  • ejc3/fcvm#1409: This PR adds the streamer host-test binary and its Containerfile build stage, which this change updates.
  • ejc3/fcvm#1425: The host test reads main.cpp to check the scene-token setup added by this PR.
Merge Risk: Minimal · up to 04d93

The host test now runs from the directory required for its relative source lookup, with no identified merge-blocking risk.

Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Already looking forward to the next diff.

Reviewed commit: 04d93cdfa3

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@ejc3 ejc3 left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NOT-A-DEFECT: the review bodies on this PR (CodeRabbit's summary or notice, Codex's receipt) carry no finding of their own.

@ejc3
ejc3 merged commit 67d383e into main Oct 29, 2026
12 of 13 checks passed
@ejc3
ejc3 deleted the fix/phone-image-test-host branch October 29, 2026 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant