Repository navigation
Phones page: phone streams send the admission token as the first message - #1427
Conversation
#1425 moved the direct token out of the frame URL into the socket's first message (DrawSource.admit) after #1422 had passed it to frameSocketUrl, so main's fleet/web failed typecheck (core/phones.ts:329: frameSocketUrl takes 2 to 3 arguments, DrawSource needs admit). The phone plan now sets admit on each source and builds the URL without it. Test: phones.test.ts "opens each phone stream with the direct seat's admission token" checks the source's admit and that the URL carries none. pnpm lint, typecheck, test (355) and the phones e2e (12) pass.
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Caution Review failedThe pull request is closed. Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Codex Review: Didn't find any major issues. 🚀 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
ejc3
left a comment
ejc3
left a comment
There was a problem hiding this comment.
NOT-A-DEFECT: the review bodies on this PR (CodeRabbit's summary or notice, Codex's receipt) carry no finding of their own.
main fails
pnpm typecheckin fleet/web since #1425 merged after #1422: core/phones.ts:329 still passed the direct token toframeSocketUrl(now 2 to 3 arguments) and built aDrawSourcewithoutadmit. The phone plan now setsadmiton each source, which the frame worker sends as the socket's first message, and the URL carries no token.Contract: phone streams authenticate exactly as the wall's direct streams do after #1425.
Evidence:
pnpm lint,pnpm typecheck(failed on main, passes here),pnpm test355 passed, phones e2e (playwright.phones.config.ts) 12 passed.opens each phone stream with the direct seat's admission tokennow checksadmiton the source and noadmitin the URL.