Skip to content

fcvm-fleet: host and tile AMIs from ejc3/fcvm main ce08eee9 (renderer keeps every tile inside its slot) - #711

Merged
ejc3 merged 1 commit into
mainfrom
fcvm-fleet-ami-ce08eee9
Oct 27, 2026
Merged

ejc3 merged 1 commit into
mainfrom
fcvm-fleet-ami-ce08eee9

Conversation

@ejc3

@ejc3 ejc3 commented Oct 27, 2026

Copy link
Copy Markdown
Owner

Host and tile AMIs from ejc3/fcvm main ce08eee9, whose renderer draws at the tallest asked stream height whose frame fits a frame slot (ejc3/fcvm#1380).

Without it, one viewer opening a tile held the whole staging wall to that tile's rate: an opened 16:9 tile asks its renderer for 720 against the wall's 432, and on terrain the 720 frame took 36 ms (render 29 ms) at the lowest budget, so the renderer drew 15 fps and the page, which shows every tile at one scene time, drew the wall at 15 to 24 fps (measured from all 16 streams: 23.8 fps over 21 s with slot-6 opened, 30.1 fps without).

  • Host: fcvm-fleet-host-x86_64-ce08eee9-20261027 (ami-022d4bacbe2aeec39), revised from the 2e2181cf image with main's recipe (fleet/ami/host/build.sh build and bake; strace installed first, which #1370's prep adds), store parts uploaded under its own prefix (17 PUTs, all 200). The build's warm VM reached its first frame in 21.4 s, the root warm-up VM in 17.1 s (6163 files, 334 MiB to prefetch). It also carries Host AMI: bake the agent's snapshot and prefetch its root volume files fcvm#1370 (agent snapshot baked, launch files prefetched) and #1361 (VUI bitstream_restriction).
  • Tile: fcvm-fleet-tile-x86_64-ce08eee9-20261027 (ami-0254d5034aa6efece), revised from the 2e2181cf image with main's tile units, renderer image from the host build (same fleet/renderer source). fleet-renderer-test in that image on its T4: 84 checks passed.

On the tile builder's T4, the new renderer drawing a 16:9 wall tile of tools/scene-move.json at budget 125,000 with a 432 stream (14.5 ms frames): adding a 720 stream and then a 1080 stream left it drawing at 432 (drawn_h 432), 30 fps, 0 slots missed over 24 s each, the taller stream scaled up.

measure-boot.sh could not run: no spot g4dn.xlarge or g4dn.metal capacity in any us-east-1 AZ at 08:55 UTC.

Supersedes #708 (2e2181cf) and #710 (e15f9e7e): both images' commits are ancestors of ce08eee9. ejc3/fcvm#1383 (renderer clouds and weather keys) merged after ce08eee9 and is not in these images; an AMI built from a later main supersedes this one. The coordinator ejc3/fcvm#1380 needs is deployed (staging coordinator from 12a83dcc, which contains ce08eee9). A renderer without #1383 ignores the scene's weather key.

… keeps every tile inside its slot)

Host fcvm-fleet-host-x86_64-ce08eee9-20261027 and tile fcvm-fleet-tile-x86_64-ce08eee9-20261027, revised from the 2e2181cf images. The renderer draws at the tallest asked height whose frame fits a slot (ejc3/fcvm#1380); the host image also carries ejc3/fcvm#1370 (agent snapshot baked, launch files prefetched).
@coderabbitai

coderabbitai Bot commented Oct 27, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 59 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 98cbd2e8-35d8-4415-835d-aedaf86bad33
Commits

Reviewing files that changed from the base of the PR and between 52716a5 and 6116657.

Files selected for processing: 1
  • fcvm-fleet.tf
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@ejc3
ejc3 marked this pull request as ready for review October 27, 2026 08:54
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 27, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-27T08:55:01.700819Z 6116657 Draft marked ready
🔒 Security Review ✅ Completed 2026-10-27T13:08:56.365298Z 6116657 Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

ejc3 commented Oct 27, 2026

Copy link
Copy Markdown
Owner Author

@codex security review

ejc3 commented Oct 27, 2026

Copy link
Copy Markdown
Owner Author

@coderabbitai review

ejc3 commented Oct 27, 2026

Copy link
Copy Markdown
Owner Author

@greptileai review

@coderabbitai

coderabbitai Bot commented Oct 27, 2026 •

Copy link
Copy Markdown
⚠️ Action not completed

Review rate limited.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@chatgpt-codex-connector

Copy link
Copy Markdown

🛡️ Codex Security Review

Security review completed. No security issues were found in this pull request.

Reviewed commit: 6116657447

View security finding report

Only the user who started this review can view the report in Codex.

ℹ️ About Codex security reviews in GitHub

This is an experimental Codex feature. Security reviews are triggered when:

  • You comment "@codex security review"
  • A regular code review gets triggered (for example, "@codex review" or when a PR is opened), and you’re opted in so security review runs alongside code review

Once complete, Codex will leave suggestions, or a comment if no findings are found.

ejc3 commented Oct 27, 2026

Copy link
Copy Markdown
Owner Author

Independent HIGH code/security and artifact review passes at 6116657. Both AMIs are available, private, owned by the fleet account and have no external launch grants. CloudTrail and SSM build metadata confirm their builder lineage and source pin; both recipe bundles match all 26 public source files at ce08eee9. Store parts and source CI were verified. Exact-head Codex code/security reviews and required AWS CI pass; no unresolved threads. CodeRabbit is quota-limited and Greptile did not respond; neither is counted as an approval.

Both older image commits are ancestors of ce08eee9, so #708 and #710 are superseded. These pins affect future launches; this deployment does not recycle existing hosts. A fresh AMI cold-boot test remains unavailable because of GPU spot capacity, as disclosed in the PR.

@ejc3
ejc3 merged commit df20ef6 into main Oct 27, 2026
3 checks passed

ejc3 commented Oct 27, 2026

Copy link
Copy Markdown
Owner Author

The combined deployment is complete at e4e019d. Terraform apply succeeded, followed by a full 2,524-resource plan with exit 0 / no changes. /infra/applied-status is published clean for this commit.

All four live latest launch templates now contain the reviewed images: host version 9 uses ami-022d4bacbe2aeec39; tile/on-demand versions 6 and pool version 3 use ami-0254d5034aa6efece. The deployed coordinator source explicitly selects $Latest in every host and tile launch path. These pins take effect on future launches; existing GPU hosts were not forcibly recycled. Superseded #708 and #710 are closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant