feat(adbc): add the Snowflake driver to the catalog - #16
Merged
Conversation
JohnSwan1503
self-requested a review
August 18, 2026 22:19
JohnSwan1503
approved these changes
Aug 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
snowflaketo the ADBC driver catalog, soampup adbc install snowflakefetches, verifies, and places the Snowflake driver library the same way it does forpostgresql.Amp releases ship the Snowflake driver archives as of edgeandnode/amp#2906, under the same
adbc-driver-<driver>-<platform>-<arch>.tar.gznaming and archive layout the catalog already assumes. The install/list/uninstall command layer is fully driver-generic, so this is only the catalog entry, its contract tests, and the feature doc's supported-driver list.Installing
snowflakefor an amp version older than the first release that ships the asset fails with a missing-asset error, which is the accurate outcome;postgresqlbehavior is unchanged.Verified with
just fmt-check,just check,just clippy(clean), andjust test(85 passed).