Repository navigation
build: ignore key order when verifying openapi specs - #270
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
ndr-brt
approved these changes
Oct 22, 2026
zuidaaa
approved these changes
Oct 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
The verify-openapi workflow sorts the keys of both the published and the newly merged spec with
yqbefore diffing them.Why it does that
mergeOpenApiSpecdoes not produce a stable key order, so the merged spec can list the same paths and responses in a different order than the published one. The plaindiffthen fails PRs that do not touch the API at all (e.g. eclipse-edc/Connector#6150). Key order has no meaning in YAML maps, so sorting both sides only removes these false positives; actual changes to the spec are still reported.Linked Issue(s)
none
🤖 Generated with Claude Code