Repository navigation
chore: fix holderPid generation - #190
Merged
wolf4ood merged 2 commits intoOct 22, 2026
Merged
Conversation
jimmarino
approved these changes
Oct 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
The onboarding agent no longer sends a
holderPidwhen it requests credentials from IdentityHub. It now reads theholderPidthat IdentityHub assigns from theLocationheader of the response.CredentialRequestno longer has aHolderPIDfield.identityhub.HolderPIDFromLocation(location)returns the last path segment of theLocationheader (.../credentials/request/{holderPid}). It returns an error if the segment is missing.holderPidreturned by IdentityHub. It then polls the request state with it, as before.Why it does that
Since eclipse-edc/IdentityHub#1219 , IdentityHub assigns the
holderPiditself. It rejects any credential request that already carries one:400 [{"message":"Property 'holderPid' must not be set, it is assigned by IdentityHub","type":"InvalidRequest"}]This breaks participant onboarding with EDC 1.0.0-RC5.
Further notes
holderPid, so the agent can't track the request against them.CredentialRequestserialization tests are updated, with a new check thatholderPidis never serialized. There are new tests forHolderPIDFromLocation. The onboarding deploy test now checks that the storedholderPidcomes from the location.