Encode failed local-activity exceptions and repair legacy text - #545
Merged
Merged
Conversation
rmcdaniel
marked this pull request as ready for review
September 24, 2026 21:30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #544.
The portable local-activity bridge stored plain exception text while marking execution rows and terminal history snapshots as Avro. Server bootstrap rejected those ordinary failed/timed-out histories after restart. This PR encodes new exceptions using the run codec and adds an idempotent migration for legacy failed, timed-out and cancelled local activities, including empty text. It leaves unrelated history values and other activity modes unchanged.
The new replay fixture covers a failed local activity with an Avro exception through cold replay and embedded history import; the corpus policy confirms it fails against the base implementation and passes with this change. Local PHP 8.4/SQLite focused tests and style checks pass. Published Python SDK 2.3.0 plus Server 2.4.2 reproduced the preflight failure before the fix.
Full supported CI and an installed-artifact restart rehearsal remain required before release.