Repository navigation
fix(builder): size the binary storage queue from the max heap - #1586
Merged
rubenporras merged 1 commit intoOct 29, 2026
Merged
Conversation
Each queued binary storage task keeps its fully linked resource in memory until it is stored. With the fixed default capacity of 15,000, a slow database lets the queue grow until it fills the heap of a standalone full build and the build fails with an OutOfMemoryError. Derive the default capacity from the maximum heap: one entry per 2 MB, at least 100 and at most 15,000 entries (2,304 for a 4.5 GB heap, the maximum from about 30 GB on). The system property binaryStorageExecutor.queueCapacity still overrides it. Log the capacity with the high water mark.
rubenporras
force-pushed
the
binary-storage-queue-heap
branch
from
October 29, 2026 15:23
d7174c8 to
36a3ef8
Compare
rubenporras
enabled auto-merge
October 29, 2026 15:24
andrewL-avlq
approved these changes
Oct 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Each queued binary storage task keeps its fully linked resource in memory until it is stored. With the fixed default capacity of 15,000, a slow database lets the queue grow until it fills the heap of a standalone full build and the build fails with an OutOfMemoryError.
Derive the default capacity from the maximum heap: one entry per 2 MB, at least 100 and at most 15,000 entries (2,304 for a 4.5 GB heap, the maximum from about 30 GB on). The system property
binaryStorageExecutor.queueCapacity still overrides it. Log the capacity with the high water mark.