feat(ui): for_each entries drawn inset in the flow view - #130
Merged
Merged
Conversation
A list-driven step showed as one box on the job page's flow view while its members ran one by one in the Progress list. The group box now grows and renders one inset chip per entry, beneath the header the ordinary box's three lines occupy: chips named as the workflow wrote them (an entry's name, else its index - _entry_keys' rule) with the engine's group@entry name on hover, a chip greening as its step_end arrives and the running one pulsing amber. The group box keeps its existing all-members-done rule, and the arrows and fan-in labels still attach to it as a whole; column layout is height-aware so a tall box no longer overlaps the node beneath it. The member list is read from the definition - a literal for_each list, or a variable: reference resolved against variables, which the realized workflow carries with the run's actual list folded in (dw/realize.py) - so historical jobs show their members too, with no server change. A list that cannot be read statically shows a muted for_each stand-in. Between one entry finishing and the next starting, activeMember now reports nothing: the run is on neither, and a chip still amber there would lie about progress. Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A list-driven step (
for_each) showed as one box on the job page's flow view while its members ran one by one in the Progress list. The group box now grows and renders one inset chip per entry:name, else index -_entry_keys's rule), with the engine'sgroup@entryname on hoverstep_endarrives; the running one pulses amberfor_eachlist, or avariable:resolved againstvariables, which the realized workflow carries with the run's actual list folded in (dw/realize.py) - so historical jobs show their members too, with no server change; a list that cannot be read statically shows a mutedfor_eachstand-inOne bug the TDD loop caught on the way: between one entry finishing and the next starting,
activeMemberstill reported the just-ended member and its chip stayed amber - it now reports nothing in that gap.Test evidence
npm run buildexit 0for_eachjob: job page screenshotted with the chips rendering, then the spec deleted🤖 Generated with Claude Code