Skip to content

Potential fix for code scanning alert no. 55: Information exposure through an exception #103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dkackman wants to merge 1 commit into from
Closed

Potential fix for code scanning alert no. 55: Information exposure through an exception #103

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions dw/workflow.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -399,9 +399,9 @@ def validation_errors(self, arguments=None):
try:
expanded = self.expanded_definition(arguments, source_indices)
except ForEachError as e:
return [{"path": e.path, "message": str(e)}]
return [{"path": e.path, "message": "Invalid for_each configuration"}]
except ConstantError as e:
return [{"path": e.path, "message": str(e)}]
return [{"path": e.path, "message": "Invalid constant reference or constant value"}]
except VariableNotFoundError:
# Every undeclared reference, not just the first one substitution
# tripped over - and reported where each sits rather than as a
Expand All @@ -414,7 +414,7 @@ def validation_errors(self, arguments=None):
# no single path inside the definition to blame, so it is
# reported against 'variables' as a whole rather than escaping
# as an unhandled exception
return [{"path": "variables", "message": str(e)}]
return [{"path": "variables", "message": "Variable cycle detected"}]
return previous_result_reference_errors(
expanded, source_indices
) + subfolder_errors(expanded, source_indices)
Expand Down
Loading