ops(release): bump the minor version for a feature - #73
Merged
Merged
Conversation
Cargo semver reads the minor of a `0.x` version as its major, so a feature moved the patch and release-plz proposed 0.2.1. This project uses the minor for its feature releases. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first release PR that the fixed workflow opened (#72) proposed 0.2.1. It should be 0.3.0.
Why it proposed a patch
Cargo semver reads the minor of a
0.xversion as its major. A feature on 1.4.0 moves the minor to 1.5.0, but a feature on 0.2.0 moves only the patch, because 0.3.0 is reserved for a breaking change. release-plz follows that rule by default, so 208 commits with dozens of scopedfeatentries still came out as 0.2.1.features_always_increment_minor = truetells it to use the minor instead. Verified against the merged master with the realv0.2.0tag:The changelog section it writes is
compare/v0.2.0...v0.3.0.The warnings in the workflow log are not a fault
The run printed eleven of these:
release-plz walks master backwards from HEAD to the last release tag, checking each commit out and comparing the package against the released one. Eleven commits in that range carry a root
Cargo.tomlthat cargo cannot parse.7f7fbb7f build: Use workspacesis the first of them: it has[workspace],[workspace.package]and[dependencies], but no[package], which makes it a virtual manifest with a dependencies section. The run that hit them ends at36f9a88 refactor(web): wire item, properties and query routes. The last warning is a different shape from the same era, whereserde-hackinheritsserdefrom aworkspace.dependenciesthat did not exist yet.That history is immutable and the warnings changed no result. They also stop on their own: once
v0.3.0is tagged, the walk coversv0.3.0..HEADand never reaches those commits again.Authorship
This branch is entirely the work of a stochastic parrot. Read it with that in mind.
🤖 Generated with Claude Code