testing: remove the temp profile dir on close; pythonEnv tests clean up - #2
Merged
Merged
Conversation
TheDrOnos
force-pushed
the
fix/temp-dir-cleanup
branch
from
September 13, 2026 02:47
fa62dfe to
4b0a46e
Compare
launchApp made the --user-data-dir with mkdtempSync inline and never kept the path, so nothing could remove it and every e2e launch left a <appId>-e2e-profile-* directory behind. closeApp now takes profileDir and removes it once the process is down, on the closed, killed and no-app paths alike; launchApp passes its own and reports it. pythonEnv.test.ts tracks the uv-stub-*/uv-none-* directories it makes and removes them in an after() hook.
CSSFrancis
force-pushed
the
fix/temp-dir-cleanup
branch
from
September 24, 2026 02:01
4b0a46e to
945f9a0
Compare
CSSFrancis
added a commit
that referenced
this pull request
Sep 24, 2026
chore: drop CHANGELOG.md again, and file #2's entry as a fragment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1.
launchAppmade the--user-data-dirwithmkdtempSyncinline and never kept the path, so nothing could remove it and every e2e launch left a<appId>-e2e-profile-*directory behind.closeAppnow takesprofileDirand removes it once the process is down, on the closed, killed and no-app paths alike;launchApppasses its own and reports it.pythonEnv.test.tstracks theuv-stub-*/uv-none-*directories it makes and removes them in anafter()hook.Verified:
npm run typecheckclean,npm run test:unit91/91 (three newcloseAppcases). The unit suite left 16 directories per run onmain, 0 here. Two real Electron launches through the patched harness (a downstream app's e2e, Windows) left 0 profile directories, was 1 per launch.