feat(contracts): introduce Illuminate\Contracts namespace - #35
Open
agissept wants to merge 1 commit into
Open
Conversation
agissept
force-pushed
the
migration/3.1-contracts
branch
from
September 11, 2026 02:17
b49ddc0 to
a95b048
Compare
- Add 39 core Contracts interfaces matching L13 signatures - Old Support\Contracts\*Interface now extend new Contracts\Support\* (backward compatible: instanceof checks work both ways) - Migrate internal callsites: Response, View, and tests This unblocks SCC-1 cycle breaking by introducing the interface layer between Support and other core components.
agissept
force-pushed
the
migration/3.1-contracts
branch
from
September 11, 2026 08:46
a95b048 to
2fceccb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Langkah fondasi migrasi framework-first (rencana #33; setelah split-map #34): introduce
Illuminate\Contracts— lapisan interface yang memutus SCC-1 (import konkret Facade/komponen → interface), prasyarat semua rename namespace berikutnya.Isi
Auth,Bus,Cache,Config,Container,Cookie,Database,Encryption,Events,Filesystem,Hashing,Http,Mail,Queue, …) dengan signature sesuai Laravel 13.Support\Contracts\*Interfacelama sekarang extendContracts\*baru →instanceofjalan dua arah, kode lama tak putus.Response,View, dan tests.Enforcement (framework-first)
By-presence: begitu komponen type-hint
Contracts\X, PHP + Psalm menangkap consumer yang tak konform. Tidak ada perubahan perilaku runtime.Catatan
composer.json— sesuai gotcha "introduce Contracts = PSR-only, JANGAN tambahilluminate/*" (menghindari false-cycle dari type-hint cross-import). Fork takreplacecontracts, jadi aman.🤖 Generated with Claude Code