Repository navigation
fix(test): parenthesize case patterns in darwin cross-compiler target - #9855
lloydmangnall wants to merge 1 commit into
Conversation
|
Important Review skippedReview was skipped as selected files did not have any reviewable changes.
 |
| Layer / File(s) | Summary |
|---|---|
Parenthesize architecture patterns t/Makefile |
The command now wraps the arm64|aarch64 and x86_64 case patterns in parentheses. Architecture mappings and Homebrew package selection are unchanged. |
Priority:
Estimated code review effort: 1 (Trivial) | ~3 minutes
Change: Bug fix
Suggested reviewers: mlwelles
Merge Risk: 
d63bc
-
The change preserves the architecture mappings while correcting the reported shell parsing issue. No actionable merge-blocking risk is evident.
Pre-merge checks | 
-
✅ Passed checks (5 passed)
-
Check name Status Explanation Docstring Coverage No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0… Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request. Description Check Check skipped - CodeRabbit’s high-level summary is enabled. Title check The title clearly and concisely identifies the main change: parenthesizing case patterns in the Darwin cross-compiler target.
-
✨ Finishing Touches
-
🧪 Generate unit tests (beta)
-
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
`install-deps-cross-compiler-darwin` fails on macOS with "syntax error near unexpected token `;;'" because /bin/sh (bash 3.2) cannot parse a `case` with unparenthesized patterns inside `$(...)`: the pattern's closing paren ends the command substitution early. Use the POSIX leading-paren pattern form so the recipe parses under macOS /bin/sh. This also unblocks `make setup` on Apple Silicon and the linux/arm64 half of `make install`. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
d327bfe to
a19a040
Compare
Description
make setup/make -C t install-deps-cross-compiler-darwinfails on macOS:macOS
/bin/shis bash 3.2, which can't parse acasewith unparenthesized patterns inside$(...): the pattern's)closes the command substitution early. Without the cross toolchain, the linux/arm64 half ofmake installthen fails withcgo: C compiler "aarch64-unknown-linux-gnu-gcc" not found.The fix uses the POSIX leading-paren form,
(arm64|aarch64)and(x86_64), which every POSIX shell accepts.Verified on macOS (Apple Silicon,
/bin/sh= GNU bash 3.2.57): the recipe frommake -nnow parses under/bin/sh -nand resolves toaarch64-unknown-linux-gnu. After installing the toolchain,make installbuilds bothdarwin/arm64andlinux/arm64binaries.Checklist
Conventional Commits syntax, leading
with
fix:,feat:,chore:,ci:, etc.🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.Summary by CodeRabbit