Repository navigation
Conversation
The writer refuses a decimal value with more digits than its column's precision, or more fractional digits than its scale, whether it comes through the API or a Parquet import. Rust 0.90's Arrow import keeps such values; its development branch rejects them too (vortex-data/vortex#10897). Recorded in docs/compatibility.md as a deliberate strictness, as AGENTS.md asks for any divergence. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011fRbYryTxfcu5j2CXwkSzd
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Decision from the #638 review: keep rejecting a decimal value that overflows its column's declared precision (or has more fractional digits than its scale), and document it.
IllegalArgumentExceptionnaming the column and row (ChunkImpl.adaptDecimal, pinned byChunkImplTest#acceptsPrecisionEdgeAndRejectsOnePast), through the API or a Parquet import.Adds the row to
docs/compatibility.md's known gaps, next to the other deliberate strictness entries. Docs only.🤖 Generated with Claude Code
https://claude.ai/code/session_011fRbYryTxfcu5j2CXwkSzd