Repository navigation
Conversation
…L errors Follow-up to #628 from its review: - hardwood's getString, getBinary and getDecimal return null instead of throwing, so a null under a REQUIRED string, binary or DECIMAL column reached the writer and was reported at its row within the chunk, and a REQUIRED FLOAT16 stored it as a silent +0.0. All four now take the importer's REQUIRED path, which reports the file row. - A DECIMAL wider than Vortex's 76 digits, which Parquet allows on a byte array, failed in DType.Decimal.of with no column name. The import now fails with an UnsupportedOperationException naming the column, as for its other unsupported types. - Tests: a REQUIRED DECIMAL column in all four physical encodings (the non-nullable BigDecimal[] path had none), the errors above, and the precision-50 vortex-jni case now holds values only an i256 holds, of both signs, which it claimed but did not. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011fRbYryTxfcu5j2CXwkSzd
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #628 (#632), from its independent review.
getString/getBinary/getDecimalreturn null instead of throwing, so a null under a REQUIRED string, binary or DECIMAL column reached the writer and was reported at its row within the chunk, and a REQUIRED FLOAT16 stored it as a silent +0.0. All four now take the importer's REQUIRED path, which reports the file row.DType.Decimal.ofwith no column name; it now fails with anUnsupportedOperationExceptionnaming the column.Tests
BigDecimal[]path had no test).ParquetImportInteropIntegrationTest's precision-50 vortex-jni case now holds values only an i256 holds, of both signs (it claimed i256 but stayed under 1e12, all negative).CHANGELOG: folded into the unreleased #628 entry.
Reviewed independently (vortex-reviewer agent): approved; its should-fix items (the same null gap in string/binary/FLOAT16, the CHANGELOG entry, all-negative test values) are in this commit.
Open question, not changed here: a Parquet decimal value that overflows its declared precision is rejected by the writer's
BigDecimalvalidation, while Rust's Arrow import does not check.🤖 Generated with Claude Code
https://claude.ai/code/session_011fRbYryTxfcu5j2CXwkSzd