Repository navigation
refactor(core): DType.Extension carries an ExtensionId, not a String - #626
Merged
Merged
Conversation
CustomExtensionIntegrationTest: validateVector states the one accepted storage shape as a record pattern instead of nested negations; the dtype helpers drop parameters always given the same value; readers opened only to assert a failure are closed; Chunk.column needs no cast. nullRows_readBackAsNull lists the null rows by id: the existing comparison against the vector() fixture still passes when the fixture stops writing nulls, so nothing caught it. CurrencyExtensionIntegrationTest asserts the expected code directly. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011fRbYrNfgxEVYukCoXYfre
The id was parsed at the file boundary and then stored as its raw string, so most consumers re-parsed it (ExtensionId.parse(ext.extensionId())) or compared strings (ExtensionId.VORTEX_TIMESTAMP.id().equals(...)). DType.Extension#extensionId() now returns the typed id, matching ExtensionDecoder/ExtensionEncoder#extensionId(): consumers switch or compare by identity on it, the reader passes the id it already parsed, and only the FlatBuffer serializer turns it back into its wire string. Strings at the boundary, types inside. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011fRbYrNfgxEVYukCoXYfre
- RaincloudConformanceIntegrationTest compared the wire string with the typed id, which compiled and was always false, so timestamp and time columns lost their unit rescaling; it compares the ids. CI does not run the raincloud tag, so nothing caught it. - A null extension id is refused where the dtype is built, now under test. - The by-id null-row assertion moves into fullScan_decodesEveryVectorAndNull: one file write instead of two, and it still fails when the fixture stops writing nulls. - VortexWriter imports ExtensionId instead of spelling the package out; the reader's test helper takes an ExtensionId, so a mistyped id no longer becomes a custom one silently. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011fRbYrNfgxEVYukCoXYfre
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #625.
DType.Extension#extensionId()returned the raw string, though the reader had already parsed it into anExtensionIdat the file boundary. So most consumers re-parsed it (ExtensionId.parse(ext.extensionId())) or compared strings (ExtensionId.VORTEX_TIMESTAMP.id().equals(...)).It now returns the typed id, matching
ExtensionDecoder/ExtensionEncoder#extensionId():Breaking: build the dtype with
ExtensionId.VORTEX_DATEorExtensionId.parse("acme.money")instead of a string.Two commits:
validateVectorstates the accepted storage shape as one record pattern.nullRows_readBackAsNullpins the null rows by id. The comparison against thevector()fixture still passed when the fixture stopped writing nulls; this test now fails.ExtensionIdchange. About 60 test constructions were rewritten by a reviewed script. Five string assertions were fixed by hand: they compiled but would have failed at run time, since anExtensionIdnever equals aString../mvnw verifyis green locally.🤖 Generated with Claude Code
https://claude.ai/code/session_011fRbYrNfgxEVYukCoXYfre