Repository navigation
fix(consent): stack the three choices below 35rem so no label breaks mid-word - #17
Merged
Merged
Conversation
…mid-word
At 390px, three columns left German, Spanish, Portuguese and Hindi labels
too narrow ("Einstellungen" touched its border, "Alle akzeptieren" wrapped).
Below 35rem the bar's choices now stack in one column, still equal in size;
from 35rem they sit in one row. The settings dialog decides by its own
width (container query; max width now 40rem), since at 600px French
"Enregistrer mes choix" still wrapped in a 34rem dialog. Buttons no longer
break inside a word (overflow-wrap: normal).
Checked in all 14 hub locales at 390px and 600px, bar and dialog: equal
size, stacked or one row as intended, every label on one line, no
horizontal overflow (280/280).
Same file as devslab.kr's src/consent/consent-ui.mjs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary (English)
Follow-up to #16, which was merged before this commit landed on its branch.
At 390px the bar's three equal columns were too narrow for some locales: "Einstellungen" touched its border, "Alle akzeptieren" wrapped, and Spanish/Portuguese/Hindi labels were tight. Now:
overflow-wrap: normal).assets/consent/consent-ui.jsstays byte-identical to devslab.kr'ssrc/consent/consent-ui.mjs(jlc488/devlab.kr#89).Verification
npm ci --ignore-scripts && npm test): 31/31 pass (the tree is identical to the one tested)._ga*, 390/1440 light/dark) — 36/36.Owner steps (code can't do these)
analytics_storage, then publish both containers.요약 (한국어)
#16이 이 커밋보다 먼저 머지되어 후속 PR로 올립니다. 390px에서 세 버튼이 좁아 독일어·스페인어·포르투갈어·힌디어 라벨이 빠듯하거나 줄바꿈되던 문제:
npm test31/31, 14개 언어 × 390/600px 280/280, 동작 36/36.analytics_storage*로 바꾸고 게시.