Repository navigation
feat(dds-solid): preserve DDS APIs with internal Ark UI primitives - #86
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DDS interactive primitives now use Ark UI internally while keeping DDS public component APIs, native form behavior, token styling, localized accessible names, and retained panels. Adds RadioGroup, optional manual Tabs and consumer IDs/native composition, and DDS-owned Dialog frames/portals with authorized external focus containers. Dialog content can retain existing native section markup while keeping generated attributes, presence, and focus behavior.
Regression coverage includes controlled/uncontrolled state, reactive attributes, native reset, SSR/hydration, accessibility, RTL, multiple toaster providers, dynamic external popup registration, and modal focus/ARIA isolation. SiteKit's tests transform the new Ark JSX dependency and wait for actual state/presence transitions. DDS pages credit Ark UI. The minor changeset updates the existing fixed six-package release group.
Validation:
pnpm run verify: all package builds/checks, docs and consumer sync.pnpm run verify:solid:teston 132d9db: 7 source contracts, 36 DOM/a11y tests, 4 SSR tests, typecheck/build.node packages/dds-solid/src/__tests__/dialog-browser.test.mjs: actual Chromium native section, external popup focus/Tab cycle, isolation, Escape cancellation, restoration.pnpm run verify:solid:releaseplus final packed verifier: fresh installed package imports, SSR/hydration, and native section/title/action node identity.pnpm run verify:site-kit:ui: 41 source contracts, 66 DOM tests, 11 SSR tests, 8 hydration tests, typecheck/build and Worker dry-run.pnpm exec changeset status: all six fixed DDS packages receive minor bumps.Full repository CI must pass on the exact final head before normal merge. The existing Changesets release PR must refresh to include this migration before publication.
CI diagnosis: run 37735949671 on e0e17fb passed the earlier stages, then SiteKit UI failed because the DDS source alias reached Ark .jsx that Node externalized without Solid transformation. The test configs now inline that dependency through the existing Solid compiler. Native click tests include their browser microtask checkpoint and wait for presence/focus readiness while keeping all assertions. Replacement exact-head run: https://github.com/devslab-kr/dds/actions/runs/37738257291 (132d9db; both source-contracts and full verify jobs passed).