Repository navigation
fix: call network thread observers on a callback thread - #364
Merged
Merged
Conversation
From M155 the network thread is also the worker thread. DTLS transport and data channel send observers ran on it, so a WebRTC call from them that needs the worker thread deadlocked. They now run in order on a shared JVM-attached thread.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From M155 the network thread is also WebRTC's worker thread. DTLS transport observers and data channel send observers were called on it, so a WebRTC call from them that needs the worker thread, such as
RTCRtpSender.getParameters(), deadlocked every connection of the factory.JavaCallbackThread).RTCDtlsTransport.unregisterObserver()still guarantees no further events once it returns.