Repository navigation
build: build WebRTC with autoninja - #357
Merged
Merged
Conversation
WebRTC moved its build from Ninja to Siso, and plain Ninja has been unsupported since the end of September 2025. The build now runs autoninja, which picks the tool the output directory is set up for: Siso, run offline, for a new one, and Ninja for one that Ninja built until "gn clean" is run on it, so existing checkouts keep building without a full rebuild.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follows up on the discuss-webrtc PSA WebRTC's build system is switching from Ninja to Siso. WebRTC builds with Siso now, and plain Ninja has been unsupported since the end of September 2025. Our WebRTC build script still called
ninja -Cdirectly.Changes
webrtc-jni/src/main/cpp/dependencies/webrtc/CMakeLists.txtrunsautoninja -Cin place ofninja -C, in all four places.autoninjapicks the tool the output directory is set up for:.gnsetsuse_siso = true.gn cleanis run on it, so nothing is rebuilt.autoninjaprints a suggestion to rungn clean.Depot_tools' plain
ninjawrapper refuses a directory Siso has built, so the build must not mix the two. All four invocations now useautoninja. The libc++ comment and the build-failure warning no longer name Ninja.Validation (windows-x86_64, M152)
gn gen,autoninja -C dir, then theapi/videoutility targets). It built with Siso: the directory holds.siso_depsand no.ninja_deps, and no command failed. The resultingobj/webrtc.libis the same size as the Ninja build's (96,542,692 bytes), and theapi/videoobjects the script re-archives are there.autoninja -C out/x64stays with Ninja and reportsninja: no work to do.:default+ SDK targets) and Linux (libc++ archive targets) paths. Siso reads the samebuild.ninja, so the same targets resolve, but CI on a cold cache is what will show it.